Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade github/codeql dependency to 2.19.4 #850

Merged
merged 16 commits into from
Feb 9, 2025
Merged

Upgrade github/codeql dependency to 2.19.4 #850

merged 16 commits into from
Feb 9, 2025

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Feb 1, 2025 •
edited by lcartey
Loading

This PR upgrades the CodeQL CLI version to 2.19.4.

CodeQL dependency upgrade checklist:

  • Confirm the code has been correctly reformatted according to the new CodeQL CLI.
  • Identify any CodeQL compiler warnings and errors, and update queries as required.
  • Validate that the github/codeql test cases succeed.
  • Address any CodeQL test failures in the github/codeql-coding-standards repository.
  • Validate performance vs pre-upgrade, using /test-performance

jketema and others added 14 commits September 16, 2024 14:20
@jketema
Remove data flow imports from queries that do not actually use it
8461696
@jketema
Fix expected test results after import changes
71570a0
@hvitved
Adapt to sourceLocationPrefix change in qltest
3387893
@jketema
Merge pull request #710 from hvitved/ql-test-source-root
b8ed7e9 
Adapt to `sourceLocationPrefix` change in `qltest`
@hvitved
Fix isDeviated predicate
9b1667e
@jketema
Merge pull request #735 from hvitved/fix-is-deviated
67956d8 
Fix `isDeviated` predicate
@jketema
Merge remote-tracking branch 'upstream/main' into next
361a80c
@jketema
Update expected test results after merging main
cf5dc69
@jketema
Update test results after QL library changes
2778d66
@MathiasVP
C++: Change an 'extends' to an 'instanceof' to make the query compile…
d77250a 
… even if IRGuard is a final class.
@jketema
Merge pull request #809 from MathiasVP/fix-do-not-rely-on-indetermina…
95ea035 
…te-values-of-errno-after-18207

C++: Change an `extends` to an `instanceof`
@jketema
Merge remote-tracking branch 'upstream/main' into next
ad2ed67
@jketema
Update expected test results
40d7800
@MichaelRFairhurst @github-actions
Upgrading github/codeql dependency to 2.19.4
16d44f1
@lcartey
Copy link
Collaborator

lcartey commented Feb 5, 2025

/test-performance

@github-actions GitHub Actions
Copy link
Author

github-actions bot commented Feb 5, 2025

🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute.

💡 If you do not hear back from me please check my status! I will report even if I fail!

@codeql-coding-standards-automation CodeQL Coding Standards Automation
Copy link

🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 


Release                            : v2.40.0
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2324585
Mean_Predicate_Execution_Time_Ms   : 49.33329796264856
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 609.8238396111128
Total_Serialized_Execution_Time_s  : 2324.585
Mean_Query_Execution_Time_s        : 0.0493332979626485
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 130.0
Number_of_Predicates               : 47120

Release                            : v2.40.0
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 3401112
Mean_Predicate_Execution_Time_Ms   : 71.22300169622851
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 833.5216392962146
Total_Serialized_Execution_Time_s  : 3401.112
Mean_Query_Execution_Time_s        : 0.0712230016962285
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 164.0
Number_of_Predicates               : 47753

Release                            : v2.40.0
Platform                           : x86-windows
Language                           : c
Total_Serialized_Execution_Time_Ms : 2750095
Mean_Predicate_Execution_Time_Ms   : 58.13416902718471
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 625.59540936855
Total_Serialized_Execution_Time_s  : 2750.095
Mean_Query_Execution_Time_s        : 0.0581341690271847
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 157.0
Number_of_Predicates               : 47306

Release                            : v2.40.0
Platform                           : x86-windows
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 3458422
Mean_Predicate_Execution_Time_Ms   : 71.6088702998178
Median_Predicate_Execution_Time_Ms : 1.0
Standard_Deviation_Ms              : 715.7345866890012
Total_Serialized_Execution_Time_s  : 3458.422
Mean_Query_Execution_Time_s        : 0.0716088702998178
Median_Predicate_Execution_Time_s  : 0.001
Percentile95_Ms                    : 185.0
Number_of_Predicates               : 48296

Release                            : v2.41.0
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2294636
Mean_Predicate_Execution_Time_Ms   : 48.58120381936358
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 604.830695062583
Total_Serialized_Execution_Time_s  : 2294.636
Mean_Query_Execution_Time_s        : 0.0485812038193635
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 125.0
Number_of_Predicates               : 47233

Release                            : v2.41.0
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 3386576
Mean_Predicate_Execution_Time_Ms   : 71.21537620389452
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 819.0328105072083
Total_Serialized_Execution_Time_s  : 3386.576
Mean_Query_Execution_Time_s        : 0.0712153762038945
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 158.0
Number_of_Predicates               : 47554

Release                            : v2.41.0
Platform                           : x86-windows
Language                           : c
Total_Serialized_Execution_Time_Ms : 2793839
Mean_Predicate_Execution_Time_Ms   : 59.077604618214885
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 617.7343684735914
Total_Serialized_Execution_Time_s  : 2793.839
Mean_Query_Execution_Time_s        : 0.0590776046182148
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 156.0
Number_of_Predicates               : 47291

Release                            : v2.41.0
Platform                           : x86-windows
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 3242287
Mean_Predicate_Execution_Time_Ms   : 67.19905075752865
Median_Predicate_Execution_Time_Ms : 1.0
Standard_Deviation_Ms              : 670.443137227368
Total_Serialized_Execution_Time_s  : 3242.287
Mean_Query_Execution_Time_s        : 0.0671990507575286
Median_Predicate_Execution_Time_s  : 0.001
Percentile95_Ms                    : 184.0
Number_of_Predicates               : 48249

Release                            : 850
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 3099015
Mean_Predicate_Execution_Time_Ms   : 62.16804750346045
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 751.7562565165155
Total_Serialized_Execution_Time_s  : 3099.015
Mean_Query_Execution_Time_s        : 0.0621680475034604
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 138.0
Number_of_Predicates               : 49849

Release                            : 850
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2329344
Mean_Predicate_Execution_Time_Ms   : 46.42161903623101
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 626.1612518762956
Total_Serialized_Execution_Time_s  : 2329.344
Mean_Query_Execution_Time_s        : 0.046421619036231
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 116.0
Number_of_Predicates               : 50178

🏁 Below are the slowest predicates for the last 2 releases vs this PR. 


Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4_Preproce__#antijoin_rhs
Execution_Time_Ms : 63221

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTable/5#79217c12
Execution_Time_Ms : 30349

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : _ExternalFlow::elementSpecMatchesSignature/6#c67d3446_Function::Function.getClassAndName/1#27b7404e___#shared
Execution_Time_Ms : 44405

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 29847

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : @element#b
Execution_Time_Ms : 37358

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : _comments#shared
Execution_Time_Ms : 26504

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : __Class::Class.accessOfBaseMemberMulti/2#6d0f61c0#ffbf_specifiers#max_range__Class::Class.accessOfBa__#join_rhs
Execution_Time_Ms : 33628

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : HardwareOrProtocolInterface::HardwareOrProtocolInterfaceClass#class#7f026171
Execution_Time_Ms : 32209

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4_Preproce__#antijoin_rhs
Execution_Time_Ms : 66713

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _ExternalFlow::elementSpecMatchesSignature/6#c67d3446_Function::Function.getClassAndName/1#27b7404e___#shared
Execution_Time_Ms : 47157

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 39301

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : FunctionEquivalence::typeSig/1#194ac728
Execution_Time_Ms : 53166

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Call::FunctionCall#2b14a517_Call::FunctionCall.getTarget/0#dispred#935da4c5_Function::Function.getP__#antijoin_rhs
Execution_Time_Ms : 27555

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : _ExternalFlow::elementSpecMatchesSignature/6#c67d3446_Function::Function.getClassAndName/1#27b7404e___#shared
Execution_Time_Ms : 67471

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTable/5#79217c12
Execution_Time_Ms : 33073

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 39638

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : _Call::Call.getAnArgument/0#dispred#0c956949_10#join_rhs_Call::FunctionCall#2b14a517_Element::Elemen__#shared
Execution_Time_Ms : 34634

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : OrderingPredicateMustBeStrictlyWeak::UserDefinedStrictlyWeakOrderingComparator#6c60f803
Execution_Time_Ms : 37907

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : FunctionEquivalence::typeSig/1#194ac728
Execution_Time_Ms : 48401

Release           : v2.41.0
Run               : 2025-01-27_15-31-47
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : _comments#shared
Execution_Time_Ms : 38869

Release           : 850
Run               : 2025-02-05_09-45-51
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 35143

Release           : 850
Run               : 2025-02-05_09-45-51
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : _comments#shared
Execution_Time_Ms : 43461

Release           : 850
Run               : 2025-02-05_09-45-51
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : _Declaration::Declaration.getADeclarationEntry/0#dispred#c5d61b67_Declaration::DeclarationEntry.isDe__#antijoin_rhs
Execution_Time_Ms : 44413

Release           : 850
Run               : 2025-02-05_09-45-51
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : Function::Function.getParameter/1#dispred#200dcf26#fbf
Execution_Time_Ms : 73079

Release           : 850
Run               : 2025-02-05_09-45-51
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : CharacterOutsideTheLanguageStandardBasicSourceCharacterSetUsedInTheSourceCode::getUniversalCharacterName/1#36dbaa42
Execution_Time_Ms : 37434

Release           : 850
Run               : 2025-02-05_09-45-51
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 39354

Release           : 850
Run               : 2025-02-05_09-45-51
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _ExternalFlow::elementSpecMatchesSignature/6#c67d3446_Function::Function.getClassAndName/1#27b7404e___#shared
Execution_Time_Ms : 41630

Release           : 850
Run               : 2025-02-05_09-45-51
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4_Preproce__#antijoin_rhs
Execution_Time_Ms : 81584

Release           : 850
Run               : 2025-02-05_09-45-51
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 26636

Release           : 850
Run               : 2025-02-05_09-45-51
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTable/5#79217c12
Execution_Time_Ms : 40397

@MichaelRFairhurst MichaelRFairhurst added this pull request to the merge queue Feb 9, 2025
Merged via the queue into main with commit 737305f Feb 9, 2025
30 checks passed
@MichaelRFairhurst MichaelRFairhurst deleted the codeql/upgrade-to-2.19.4 branch February 9, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcartey lcartey lcartey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcartey @MichaelRFairhurst @jketema @hvitved @MathiasVP